![]() Perhaps we could introduce get_blog_options() (or perhaps a deliberately more cryptic name) that attempts to fetch all of the options we need for a single site in a single query.Īs an actual implementation, is favicon something for Settings, or for Appearance? Our cognitive approach here will affect our code implementation. Any theme support will not be detectable. In particular, because my-sites and the admin bar will need to do get_blog_option() against each blog. Ultimately, though, we're going to need a DB option. As it is, though, core does provide for an early exit with a 404 via PHP.) htaccess if we're installed at the root and rewrite it to the uploaded file, and thus specify a proper favicon.ico file in the. (We could also even intercept /favicon.ico requests via. Unsure if browsers rely on the last favicon specified. ![]() However I don't necessarily find this to be a requirement - we likely can echo out a favicon without much side effect. Theme support is desired basically to ensure that the theme avoids handling/printing an existing favicon. Once specified, we generate the tag automatically. Responsive improvements for the Site Icon, making the feature more friendly for mobile devices with smaller screen size.ġ6434.14.diff ( 8.2 KB) - added by obenland 7 years ago.ġ ( 24.1 KB) - added by celloexpressions 7 years ago.įirst-pass at site icons and a cropped-image control in the Customizer.ġ ( 1.3 KB) - added by lucaspiller 7 years ago.ġ6434.15.diff ( 19.2 KB) - added by obenland 7 years ago.ġ6434.16.diff ( 21.7 KB) - added by obenland 7 years ago.ġ6434.17.diff ( 22.3 KB) - added by celloexpressions 7 years ago.Ĭustomizer: skip cropping if image is the right size use full image size as default setting value.ġ6434.18.diff ( 4.6 KB) - added by obenland 7 years ago.ġ6434.19.diff ( 9.2 KB) - added by obenland 7 years ago.ġ6434.20.diff ( 10.0 KB) - added by obenland 7 years ago.ġ6434.21.diff ( 10.3 KB) - added by jorbin 7 years ago.ġ6434.22.diff ( 10.3 KB) - added by obenland 7 years ago.ġ6434.23.diff ( 41.5 KB) - added by obenland 7 years ago.ġ6434.24.diff ( 86.0 KB) - added by obenland 7 years ago.ġ6434.25.diff ( 86.5 KB) - added by obenland 7 years ago.Ĭore then provides a UI to upload/specify a favicon. Saving settings page doesn't delete site_icon anymoreġ6434-responsive.patch ( 3.2 KB) - added by tyxla 7 years ago. Selecting an image with minimal accepted dimensions skips crop dialog and sets image instantlyġ6434.13.diff ( 10.0 KB) - added by jipmoors 7 years ago. When the current attachment has been re-selected just refresh metadataġ6434.12.diff ( 8.3 KB) - added by jipmoors 7 years ago. Moving the admin_head action to admin-filters.phpġ6434.11.diff ( 5.5 KB) - added by jipmoors 7 years ago. Patch will have to be updated for size reasonsġ6434.8.diff ( 37.4 KB) - added by obenland 7 years ago.ġ6434.9.diff ( 37.3 KB) - added by obenland 7 years ago.ġ6434.10.diff ( 1.1 KB) - added by kraftbj 7 years ago. Updatign last patch to include minor no-js improvementsġ6434.7.diff ( 36.6 KB) - added by flixos90 7 years ago.įixed image cropping bug when Javascript was disabledīrowser.2.png ( 44.1 KB) - added by markjaquith 7 years ago. Updating the patch from 16434.4.diff to fix the single equals operator and use relative height when scaling the preview in the admin.ġ6434.6.diff ( 36.6 KB) - added by tyxla 7 years ago. Re-integrated ico library, large scale refactoring, same great taste.ġ6434-06.patch ( 8.9 KB) - added by brandondove 7 years ago.ġ6434.3.diff ( 37.0 KB) - added by obenland 7 years ago.ġ6434.4.diff ( 36.6 KB) - added by obenland 7 years ago.īrowser.png ( 46.5 KB) - added by obenland 7 years ago.īrowser image, to be added in src/wp-admin/images/.ġ6434.5.diff ( 35.9 KB) - added by tyxla 7 years ago. Re-formatted version of the ico library which isn't so painful to read. Remove ico library, clean things up a bit, add in nonces Included ico2_3.php, "remove" functionality, and refactoring of get_favicon_thumbnail_img() to get_favicon_img()ġ6434.2.diff ( 21.1 KB) - added by jorbin 10 years ago. Ico2_3.php ( 26.9 KB) - added by brandondove 10 years ago. ![]() Refactoring to some functions from previous patch. Update includes new API calls to generate the thumbnail IMG tag, verify existence of a custom favicon, and get the favicon file path. Ico2_2.php ( 26.8 KB) - added by brandondove 11 years ago.ġ6434.diff ( 6.3 KB) - added by jorbin 11 years ago. Trac-16434-01.patch ( 16.8 KB) - added by TomAuger 11 years ago.Įarly patch with basic add image functionality
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |